[PATCH v2] iommu/vt-d: add NUMA awareness to intel_alloc_coherent()
From: Eric Dumazet <hidden>
Date: 2018-02-01 06:34:05
Also in:
linux-iommu, lkml
Subsystem:
iommu subsystem, the rest · Maintainers:
Joerg Roedel, Will Deacon, Linus Torvalds
From: Eric Dumazet <edumazet@google.com> Some devices (like mlx4) try hard to allocate memory on selected NUMA node, but it turns out intel_alloc_coherent() is not NUMA aware yet. Note that dma_generic_alloc_coherent() in arch/x86/kernel/pci-dma.c gets this right. Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Benjamin Serebrin <redacted> Cc: David Woodhouse <dwmw2@infradead.org> Cc: Joerg Roedel <joro@8bytes.org> --- v2: no fallback to alloc_pages(), this is not needed and might even hurt in OOM cases. drivers/iommu/intel-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index a1373cf343269455808f66ad18dc0a2fb7aa73f2..3c538466a98bdb8fffdca688462b1350d536791b 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c@@ -3735,7 +3735,7 @@ static void *intel_alloc_coherent(struct device *dev, size_t size, } if (!page) - page = alloc_pages(flags, order); + page = alloc_pages_node(dev_to_node(dev), flags, order); if (!page) return NULL; memset(page_address(page), 0, size);
_______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu