Re: [PATCH net-next 2/5] net/smc: fix structure size
From: David Miller <davem@davemloft.net>
Date: 2018-02-22 19:10:36
Also in:
linux-s390
From: Ursula Braun <redacted> Date: Wed, 21 Feb 2018 12:32:32 +0100
quoted hunk ↗ jump to hunk
diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h index ab240b37ad11..d2012fd22100 100644 --- a/net/smc/smc_cdc.h +++ b/net/smc/smc_cdc.h@@ -48,7 +48,7 @@ struct smc_cdc_msg { struct smc_cdc_producer_flags prod_flags; struct smc_cdc_conn_state_flags conn_state_flags; u8 reserved[18]; -} __aligned(8); +} __packed; /* format defined in RFC7609 */
Hold on, __packed should only be used as the absolute last possible option to fix structure layout problems. Also, a sub-structure of smc_cdc_msg, union smc_cdc_cursor, is still marked with __aligned(8). That makes no sense at all. Please fix this without using __packed, as __packed has a severe detrimental effect on code generation for accessing such structure on several cpu architectures. Also, if this these are legitimate bug fixes you should target those at 'net' not 'net-next'. Thank you.