Re: [PATCH iproute2-next v2] ip link: add support to display extended tun attributes

2018-02-20, 09:34:15 -0700, David Ahern wrote:

On 2/20/18 5:43 AM, Sabrina Dubroca wrote:

quoted

Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Stefano Brivio <redacted>
---
v2: define print_onoff to print flags, fix checkpatch warnings, drop
header changes

 ip/iptuntap.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 86 insertions(+)

applied to iproute2-next.

Thanks!

quoted

diff --git a/ip/iptuntap.c b/ip/iptuntap.c
index 4628db2832b4..07253870472f 100644
--- a/ip/iptuntap.c
+++ b/ip/iptuntap.c

@@ -469,3 +469,89 @@ int do_iptuntap(int argc, char **argv)
 		*argv);
 	exit(-1);
 }
+
+static void print_owner(FILE *f, uid_t uid)
+{
+	struct passwd *pw = getpwuid(uid);
+
+	if (pw)
+		fprintf(f, "user %s ", pw->pw_name);
+	else
+		fprintf(f, "user %u ", uid);
+}
+
+static void print_group(FILE *f, gid_t gid)
+{
+	struct group *group = getgrgid(gid);
+
+	if (group)
+		fprintf(f, "group %s ", group->gr_name);
+	else
+		fprintf(f, "group %u ", gid);
+}
+

Those helpers can be re-used to make 'ip tuntap show' better too.

Actually, I didn't want to do that, because that command currently
always prints a numeric value, and I don't want to change the output
format (in case someone is parsing it and expects the raw uid/gid).

-- 
Sabrina