Thread (9 messages) 9 messages, 5 authors, 2018-02-21

Re: [PATCH v2] sched: report if filter is too large to dump

flat view

From: David Miller <davem@davemloft.net>
Date: 2018-02-21 02:58:13

From: Roman Kapl <redacted>
Date: Mon, 19 Feb 2018 21:32:51 +0100
So far, if the filter was too large to fit in the allocated skb, the
kernel did not return any error and stopped dumping. Modify the dumper
so that it returns -EMSGSIZE when a filter fails to dump and it is the
first filter in the skb. If we are not first, we will get a next chance
with more room.

I understand this is pretty near to being an API change, but the
original design (silent truncation) can be considered a bug.

Note: The error case can happen pretty easily if you create a filter
with 32 actions and have 4kb pages. Also recent versions of iproute try
to be clever with their buffer allocation size, which in turn leads to

Signed-off-by: Roman Kapl <redacted>
Applied and queued up for -stable, thanks Roman.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help