Thread (3 messages) flat view 3 messages, 2 authors, 2018-02-21

Re: [PATCH iproute2-next] color: disable color when json output is requested

From: Vincent Bernat <hidden>
Date: 2018-02-21 06:07:03

 ❦ 20 février 2018 16:04 -0800, Stephen Hemminger [off-list ref] :
quoted
Instead of declaring -color and -json exclusive, ignore -color when
-json is provided. The rationale is to allow to put -color in an alias
for ip while still being able to use -json. -color is merely a
presentation suggestion and we can assume there is nothing to color in
the JSON output.

Signed-off-by: Vincent Bernat <redacted>
Looks fine to me, this could even go into master.
Need to update man page and make sure behavior is consistent
across ip, tc, and bridge commands.
Currently, in master or net-next, only the "ip" command has a -color
option.
-- 
The human race is a race of cowards; and I am not only marching in that
procession but carrying a banner.
		-- Mark Twain
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help