Re: [PATCH net-next] cxgb4vf: Forcefully link up virtual interfaces
From: David Miller <davem@davemloft.net>
Date: 2018-02-23 17:45:30
From: Ganesh Goudar <redacted> Date: Fri, 23 Feb 2018 20:36:53 +0530
quoted hunk ↗ jump to hunk
@@ -92,6 +92,18 @@ module_param(msi, int, 0644); MODULE_PARM_DESC(msi, "whether to use MSI-X or MSI"); /* + * Logic controls. + * =============== + */ + +/* The Virtual Interfaces are connected to an internal switch on the chip + * which allows VIs attached to the same port to talk to each other even when + * the port link is down. As a result, we generally want to always report a + * VI's link as being "up". + */ +#define force_link_up 1
Please don't do this, just perform the actions unconditionally.