Thread (2 messages) flat view 2 messages, 2 authors, 2018-02-27

Re: [net 1/1] tipc: correct initial value for group congestion flag

From: David Miller <davem@davemloft.net>
Date: 2018-02-27 16:47:06

From: Jon Maloy <redacted>
Date: Mon, 26 Feb 2018 20:14:04 +0100
In commit 60c253069632 ("tipc: fix race between poll() and
setsockopt()") we introduced a pointer from struct tipc_group to the
'group_is_connected' flag in struct tipc_sock, so that this field can
be checked without dereferencing the group pointer of the latter struct.

The initial value for this flag is correctly set to 'false' when a
group is created, but we miss the case when no group is created at
all, in which case the initial value should be 'true'. This has the
effect that SOCK_RDM/DGRAM sockets sending datagrams never receive
POLLOUT if they request so.

This commit corrects this bug.

Reported-by: Hoang Le <redacted>
Signed-off-by: Jon Maloy <redacted>
Applied, thanks.

Please provide a proper Fixes: tag next time.  I added it for you
in this case.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help