Re: [PATCH net] bridge: Fix VLAN reference count problem
From: David Miller <hidden>
Date: 2018-02-26 20:19:39
Also in:
bridge
From: David Miller <hidden>
Date: 2018-02-26 20:19:39
Also in:
bridge
From: Ido Schimmel <redacted> Date: Sun, 25 Feb 2018 21:59:06 +0200
When a VLAN is added on a port, a reference is taken on the
corresponding master VLAN entry. If it does not already exist, then it
is created and a reference taken.
However, in the second case a reference is not really taken when
CONFIG_REFCOUNT_FULL is enabled as refcount_inc() is replaced by
refcount_inc_not_zero().
Fix this by using refcount_set() on a newly created master VLAN entry.
Fixes: 251277598596 ("net, bridge: convert net_bridge_vlan.refcnt from atomic_t to refcount_t")
Signed-off-by: Ido Schimmel <redacted>Applied and queued up for -stable, thanks!