Thread (31 messages) flat view 31 messages, 4 authors, 2018-02-15

Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification

From: David Miller <davem@davemloft.net>
Date: 2018-02-14 19:02:58

From: Sowmini Varadhan <redacted>
Date: Wed, 14 Feb 2018 14:01:10 -0500
On (02/14/18 10:50), Santosh Shilimkar wrote:
quoted
generic comment and please update it where it is applicable
in terms of variable names, notifiers etc.

RDS support true zero copy already with RDMA transport so some of
this code can easily get confused.

So I suggest something like below.
s/zerocopy/zeromsgcopy
s/zcopy/zmsgcopy
s/zcookie/zmsgcpycookie
s/znotifier/zmsgcpynotifier	
I'd like to hear some additional opinions from the list on this: 
the existing socket API for TCP etc.  already uses ZEROCOPY, and other
than extending variable names (and putting me at risk of violating the
"fit within 80 chars per line" requirement, leading to not-so-pretty
line wraps), I'm not seeing much value in this.
I agree, this name change requires seems pointless.  Just keep the names
the way they are, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help