Re: [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker

From: Davide Caratti <redacted>
Date: Tue, 13 Feb 2018 10:58:01 +0100

On Mon, 2018-02-12 at 15:19 -0500, Alexander Aring wrote:

quoted

@@ -211,7 +212,8 @@ int tcf_generic_walker(struct tc_action_net *tn, struct sk_buff *skb,
 	} else if (type == RTM_GETACTION) {
 		return tcf_dump_walker(idrinfo, skb, cb);
 	} else {
-		WARN(1, "tcf_generic_walker: unknown action %d\n", type);
+		WARN(1, "tcf_generic_walker: unknown command %d\n", type);
+		NL_SET_ERR_MSG(extack, "tcf_generic_walker: unknown command\n");

minor nit: maybe we don't need the '\n' in the above message? 

Agreed, the newline should be removed.