Thread (27 messages) flat view 27 messages, 4 authors, 2018-02-15

Re: [PATCH net-next v2 03/16] l2tp: don't use inet_shutdown on tunnel destroy

From: James Chapman <jchapman@katalix.com>
Date: 2018-02-12 17:23:47

On 12/02/18 16:22, David Miller wrote:
From: James Chapman <jchapman@katalix.com>
Date: Mon, 12 Feb 2018 10:11:07 +0000
quoted
Previously, if a tunnel was closed, we called inet_shutdown to mark
the socket as unconnected such that userspace would get errors and
then close the socket. This could race with userspace closing the
socket. Instead, leave userspace to close the socket in its own time
(our tunnel will be detached anyway).

Fixes: 309795f4be ("l2tp: Add netlink control API for L2TP")
 ...
quoted
 BUG: unable to handle kernel NULL pointer dereference at 00000000000000a0
 IP: __lock_acquire+0x263/0x1630
Ok, all of these are like this.

Please fix this up, put the kernel log message into the message body
and add an appropriate signoff.

Thank you.
Oh stupid me. I'll do so straight away. Sorry!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help