Re: [PATCH] flex_can: Correct the checking for frame length in flexcan_start_xmit()
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2018-01-02 11:17:17
Also in:
linux-can
On 01/02/2018 04:44 AM, Luu An Phu wrote:
From: "phu.luuan" <redacted> The flexcan_start_xmit() function compares the frame length with data register length to write frame content into data[0] and data[1] register. Data register length is 4 bytes and frame maximum length is 8 bytes. Fix the check that compares frame length with 3. Because the register length is 4. Signed-off-by: Luu An Phu <redacted>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net> Thanks for this improvement! Best regards, Oliver
quoted hunk ↗ jump to hunk
--- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 0626dcf..760d2c0 100644 --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c@@ -526,7 +526,7 @@ static int flexcan_start_xmit(struct sk_buff *skb, struct net_device *dev) data = be32_to_cpup((__be32 *)&cf->data[0]); flexcan_write(data, &priv->tx_mb->data[0]); } - if (cf->can_dlc > 3) { + if (cf->can_dlc > 4) { data = be32_to_cpup((__be32 *)&cf->data[4]); flexcan_write(data, &priv->tx_mb->data[1]); }