On Wed, Jan 31, 2018 at 7:34 PM, Dave Watson [off-list ref] wrote:

On 01/31/18 05:22 PM, Vakul Garg wrote:

quoted

quoted

quoted

On second though in stable we should probably just disable async tfm
allocations.
It's simpler. But this approach is still good for -next


Gilad

I agree with Gilad, just disable async for now.

How to do it? Can you help with the api name?

*aead = crypto_alloc_aead("gcm(aes)", 0, CRYPTO_ALG_ASYNC);

https://github.com/ktls/net_next_ktls/commit/f3b9b402e755e4b0623fa83f88137173fc249f2d

I said disabling async tfms is the right way to go for -stable since
it's the simplest and less risky way
of plugging this bug.

I don't think this is the way to go for -next (and it seems davem
agrees with me). Vakul's
patch looks good to me for now.

quoted

quoted

If the flag MSG_DONTWAIT is set, we should be returning -EINPROGRESS and
not wait for a response.  I had started working on a patch for that, but it's
pretty tricky to get right.

That would be a great addition, but I don't think we need to wait for
that. It can come later.

Gilad
-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru