Re: [PATCH for-4.14.y 0/5] e1000e: Upstream fixes for linux-4.14.y

On 2017/12/19 15:27, Jeff Kirsher wrote:

On Tue, 2017-12-19 at 10:10 +0900, Benjamin Poirier wrote:

quoted

On 2017/12/18 12:59, Greg KH wrote:

quoted

On Mon, Dec 11, 2017 at 10:58:10PM +0100, Christian Hesse wrote:

quoted

Greg KH [off-list ref] on Tue, 2017/12/05 08:35:

quoted

On Tue, Dec 05, 2017 at 08:23:27AM +0100, Christian Hesse wrote:

quoted

Greg KH [off-list ref] on Mon, 2017/12/04 19:37:  

quoted

On Mon, Dec 04, 2017 at 04:47:00PM +0100, Christian Hesse
wrote:  

quoted

Amit Pundir [off-list ref] on Mon, 2017/11/27
18:23:    

quoted

Hi Greg,

Found few e100e upstream fixes from Benjamin Poirier in
lede
source tree, https://git.lede-project.org/?p=source.git,
and
these fixes seem reasonable enough for 4.14.y too.

Also submitting an e1000e buffer overrun fix by Sasha
Neftin.

Cherry-picked and build tested for linux v4.14.2 for
ARCH=arm/arm64.

Regards,
Amit Pundir


Benjamin Poirier (4):
  e1000e: Fix error path in link detection
  e1000e: Fix return value test
  e1000e: Separate signaling for link check/link up
  e1000e: Avoid receiver overrun interrupt bursts

Sasha Neftin (1):
  e1000e: fix buffer overrun while the I219 is processing
DMA
    transactions    

Hello everybody,

looks like one of these breaks connectivity on my Thinkpad
X250.
Just downgraded to linux 4.14.2 to verify.    

Can you try the -rc release I just did?  It has a fix for this
series in
it.  

It connects with the notebook's built in ethernet port (did not
check with
4.14.3) but still fails to see a link when placed in docking
station.  

Do you have the same issues with 4.15-rc2?

Just a short heads-up and final result for this thread...
The issue is fixed with Benjamin's patch:

https://patchwork.kernel.org/patch/10104349/

Any word on getting this patch into Linus's tree anytime soon?

Apparently the intel maintainer was unavailable recently:
https://www.mail-archive.com/netdev@vger.kernel.org/msg206192.html

The patch is now in there:
https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git/l
og/?h=dev-queue
but that only makes it slated for 4.16 AFAIK.

Jeff, given that this issue breaks networking for many people, wouldn't
it be more appropriate to submit the patch for 4.15?

Yeah, I will send to Dave's net tree (4.15) for inclusion.

Jeff, I see that the patch is still in your "next-queue". Meanwhile
another 4.15 rc has been released and I've gotten more user reports that
e1000e is broken.