Thread (4 messages) 4 messages, 4 authors, 2018-02-27

Re: [PATCH] wireless: zd1211rw: remove redundant assignment of pointer 'q'

From: Andy Shevchenko <hidden>
Date: 2018-01-31 12:59:01
Also in: kernel-janitors, linux-wireless, lkml

On Tue, Jan 30, 2018 at 8:25 PM, Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

Pointer q is initialized and then almost immediately afterwards being
re-assigned the same value. Remove the second redundant assignment.
Don't you see strange that in the same context of the patch two users
of q are present?

How did you test this?
Cleans up clang warning:
drivers/net/wireless/zydas/zd1211rw/zd_mac.c:503:23: warning: Value
stored to 'q' during its initialization is never read
-       q = &mac->ack_wait_queue;
        spin_lock_irqsave(&q->lock, flags);

        skb_queue_walk(q, skb) {


-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help