Thread (4 messages) 4 messages, 3 authors, 2018-01-22

Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is_router

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2018-01-19 00:23:09
Also in: bridge, lkml

On Thu, 18 Jan 2018 17:37:45 -0600
"Gustavo A. R. Silva" [off-list ref] wrote:
Return statements in functions returning bool should use
true/false instead of 1/0.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
LGTM

Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is not enabled")
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help