Thread (11 messages) 11 messages, 4 authors, 2018-01-02

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

From: Julia Lawall <hidden>
Date: 2018-01-02 13:55:36
Also in: amd-gfx, dri-devel, kernel-janitors, linux-arm-kernel, linux-ext4, linux-media, linux-s390, linux-scsi, lkml


On Tue, 2 Jan 2018, Bob Peterson wrote:
----- Original Message -----
| Drop newline at the end of a message string when the printing function adds
| a newline.

Hi Julia,

NACK.

As much as it's a pain when searching the source code for output strings,
this patch set goes against the accepted Linux coding style document. See:

https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
I don't think that's the case:

"However, never break user-visible strings such as printk messages,
because that breaks the ability to grep for them."

julia
Regards,

Bob Peterson
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help