Re: [PATCH 04/36] usercopy: Prepare for usercopy whitelisting

On Wed, Jan 10, 2018 at 10:28 AM, Christopher Lameter [off-list ref] wrote:

On Tue, 9 Jan 2018, Kees Cook wrote:

quoted

+struct kmem_cache *kmem_cache_create_usercopy(const char *name,
+                     size_t size, size_t align, slab_flags_t flags,
+                     size_t useroffset, size_t usersize,
+                     void (*ctor)(void *));

Hmmm... At some point we should switch kmem_cache_create to pass a struct
containing all the parameters. Otherwise the API will blow up with
additional functions.

quoted

index 2181719fd907..70c4b4bb4d1f 100644

--- a/include/linux/stddef.h
+++ b/include/linux/stddef.h

@@ -19,6 +19,8 @@ enum {
 #define offsetof(TYPE, MEMBER)       ((size_t)&((TYPE *)0)->MEMBER)
 #endif

+#define sizeof_field(structure, field) sizeof((((structure *)0)->field))
+
 /**
  * offsetofend(TYPE, MEMBER)
  *

Have a separate patch for adding this functionality? Its not a slab
maintainer
file.

Good idea; I've done this now.

Rest looks ok.

Acked-by: Christoph Lameter <redacted>

Thanks!

-Kees

-- 
Kees Cook
Pixel Security

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>