Thread (2 messages) flat view 2 messages, 2 authors, 2018-01-11

Re: [PATCH 26/32] aio: refactor read/write iocb setup

From: Christoph Hellwig <hch@lst.de>
Date: 2018-01-11 13:38:32
Also in: linux-api, linux-fsdevel, lkml

On Wed, Jan 10, 2018 at 04:19:53PM -0500, Jeff Moyer wrote:
quoted
+static int aio_prep_rw(struct kiocb *req, struct iocb *iocb)
+{
+	int ret;
+
+	req->ki_filp = fget(iocb->aio_fildes);
+	if (unlikely(!req->ki_filp))
+		return -EBADF;
+	req->ki_complete = aio_complete_rw;
+	req->ki_flags = 0;
The above assignment seems superfluous...
Thanks, fixed.

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help