Thread (4 messages) flat view 4 messages, 4 authors, 2018-01-25

Re: [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down

From: David Miller <davem@davemloft.net>
Date: 2018-01-25 21:22:26

From: David Ahern <redacted>
Date: Wed, 24 Jan 2018 19:45:29 -0800
IPv6 allows routes to be installed when the device is not up (admin up).
Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
there is no reason for IPv6 to allow it, so check the flags and deny if
device is admin down.

Signed-off-by: David Ahern <redacted>
---
v3
- moved err=-ENETDOWN under the if check per Eric's request
- left the up check using dev->flags for consistency with IPv4
  and that it is used more often in ipv4 and ivp6 code than
  netif_running

v2
- missed setting err to -ENETDOWN (thanks for catching that Roopa)
Applied, thanks David.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help