Re: [PATCH net-next 0/7] RDS zerocopy support

Hi Sowmini,

On 1/24/2018 3:45 AM, Sowmini Varadhan wrote:

This patch series follows up on the RFC and subsequent review comments
at https://patchwork.ozlabs.org/cover/862248/

Review comments addressed are
- drop MSG_PEEK change for sk_error_queue
- (patch4) batch of SO_EE_ORIGIN_MAX_ZCOOKIES (#defined to 8) is sent up
   as part of the data in the error notification. The ancillary data in
   with this notification specifies the number of cookies in ee_data,
   with the ee_origin is set to SO_EE_ORIGIN_ZCOOKIE
- (patch4, patch5) allocate the skb to be used for error notification
   up-front (in rds_sendmsg()) so that we never have to fail due to skb
   allocation failure in the callback routine.
- other minor review fixes around refactoring code for the setsockopt
   of ZEROCOPY, use iov_iter_npages()  etc.

This patch series also updates the selftests/net/msg_zerocopy.c to support
PF_RDS sockets (both with and without zerocopy)

RDS changes looks like largely good but I need some time to look at the
completion notification and send side changes. Will try to provide
feedback in next few days.

regards,
Santosh