Re: [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II support

Hi Jiri,

On Thu, Jan 18, 2018 at 2:13 AM, Jiri Benc [off-list ref] wrote:

Looks much better.

On Wed, 17 Jan 2018 09:32:51 -0800, William Tu wrote:

quoted

+     OVS_ERSPAN_OPT_IDX,     /* be32 index */

Why don't you convert this to u32 while passing to/from user space?

quoted

+     [OVS_ERSPAN_OPT_IDX]    = { .len = sizeof(u32) },

sizeof(__be32) but see above.

Thanks,

 Jiri

Thanks. Your suggestion makes sense.
In the beginning I just want to avoid another ntoh, hton conversion.
Since the ERSPAN iproute2 also assume u32 to/from userspace, I will
change it here to use u32.

William