Thread (14 messages) flat view 14 messages, 2 authors, 2018-01-19
STALE3132d REVIEWED: 1 (0M)

1 review trailer.

[PATCH net-next 12/12] nfp: bpf: disable all ctrl vNIC capabilities

From: Jakub Kicinski <hidden>
Date: 2018-01-18 02:52:23
Subsystem: bpf jit for nfp nics, netronome ethernet drivers, networking drivers, the rest · Maintainers: Jakub Kicinski, Andrew Lunn, "David S. Miller", Eric Dumazet, Paolo Abeni, Linus Torvalds

BPF firmware currently exposes IRQ moderation capability.
The driver will make use of it by default, inserting 50 usec
delay to every control message exchange.  This cuts the number
of messages per second we can exchange by almost half.

None of the other capabilities make much sense for BPF control
vNIC, either.  Disable them all.

Signed-off-by: Jakub Kicinski <redacted>
Reviewed-by: Dirk van der Merwe <redacted>
---
 drivers/net/ethernet/netronome/nfp/bpf/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/bpf/main.c b/drivers/net/ethernet/netronome/nfp/bpf/main.c
index 5f021d0c88a4..4ee11bf2aed7 100644
--- a/drivers/net/ethernet/netronome/nfp/bpf/main.c
+++ b/drivers/net/ethernet/netronome/nfp/bpf/main.c
@@ -389,7 +389,7 @@ const struct nfp_app_type app_bpf = {
 	.id		= NFP_APP_BPF_NIC,
 	.name		= "ebpf",
 
-	.ctrl_cap_mask	= ~0U,
+	.ctrl_cap_mask	= 0,
 
 	.init		= nfp_bpf_init,
 	.clean		= nfp_bpf_clean,
-- 
2.15.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help