Thread (5 messages) flat view 5 messages, 2 authors, 2018-01-17
STALE3142d REVIEWED: 2 (0M)

2 review trailers.

[PATCH iproute2 1/3] iplink: Validate minimum tx rate is less than maximum tx rate

From: Gal Pressman <hidden>
Date: 2018-01-16 13:42:43
Subsystem: the rest · Maintainer: Linus Torvalds

According to the documentation (man ip-link), the minimum TXRATE should
be always <= Maximum TXRATE, but commit f89a2a05ffa9 ("Add support to
configure SR-IOV VF minimum and maximum Tx rate through ip tool") didn't
enforce it.

Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool")
Cc: Sucheta Chakraborty <redacted>
Signed-off-by: Gal Pressman <redacted>
Reviewed-by: Eran Ben Elisha <redacted>
Reviewed-by: Leon Romanovsky <redacted>
---
 ip/iplink.c | 8 ++++++++
 1 file changed, 8 insertions(+)
diff --git a/ip/iplink.c b/ip/iplink.c
index 4c96711..22c9a29 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -539,6 +539,14 @@ static int iplink_parse_vf(int vf, int *argcp, char ***argvp,
 			if (tivt.max_tx_rate == -1)
 				tivt.max_tx_rate = tmax;
 		}
+
+		if (tivt.max_tx_rate && tivt.min_tx_rate > tivt.max_tx_rate) {
+			fprintf(stderr,
+				"Invalid min_tx_rate %d - must be <= max_tx_rate %d\n",
+				tivt.min_tx_rate, tivt.max_tx_rate);
+			return -1;
+		}
+
 		addattr_l(&req->n, sizeof(*req), IFLA_VF_RATE, &tivt,
 			  sizeof(tivt));
 	}
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help