Thread (3 messages) flat view 3 messages, 2 authors, 2018-01-15

Re: [PATCH net-next] net: dpaa: change while() to if() in dpaa_fq_setup()

From: yuan linyu <hidden>
Date: 2018-01-13 09:24:57

i am wrong, ignore it.

On 六, 2018-01-13 at 17:15 +0800, yuan linyu wrote:
quoted hunk ↗ jump to hunk
From: yuan linyu <redacted>

while loop is not needed, because list_for_each_entry() already check all fq.

Signed-off-by: yuan linyu <redacted>
---
 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index 7caa8da..fd0e411 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -931,7 +931,7 @@ static void dpaa_fq_setup(struct dpaa_priv *priv,
 	}
 
 	 /* Make sure all CPUs receive a corresponding Tx queue. */
-	while (egress_cnt < DPAA_ETH_TXQ_NUM) {
+	if (egress_cnt < DPAA_ETH_TXQ_NUM) {
 		list_for_each_entry(fq, &priv->dpaa_fq_list, list) {
 			if (fq->fq_type != FQ_TYPE_TX)
 				continue;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help