Thread (2 messages) flat view 2 messages, 2 authors, 2018-01-10

Re: [PATCH bpf] bpf: arsh is not supported in 32 bit alu thus reject it

From: Alexei Starovoitov <hidden>
Date: 2018-01-10 22:57:09

On Wed, Jan 10, 2018 at 08:04:37PM +0100, Daniel Borkmann wrote:
The following snippet was throwing an 'unknown opcode cc' warning
in BPF interpreter:

  0: (18) r0 = 0x0
  2: (7b) *(u64 *)(r10 -16) = r0
  3: (cc) (u32) r0 s>>= (u32) r0
  4: (95) exit

Although a number of JITs do support BPF_ALU | BPF_ARSH | BPF_{K,X}
generation, not all of them do and interpreter does neither. We can
leave existing ones and implement it later in bpf-next for the
remaining ones, but reject this properly in verifier for the time
being.

Fixes: 17a5267067f3 ("bpf: verifier (add verifier core)")
Reported-by: syzbot+93c4904c5c70348a6890@syzkaller.appspotmail.com
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
ouch. it's been there forever.
Applied, Thank you Daniel.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help