Thread (7 messages) flat view 7 messages, 3 authors, 2018-01-10

Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

From: David Miller <davem@davemloft.net>
Date: 2018-01-10 20:31:29

From: Cong Wang <redacted>
Date: Tue,  9 Jan 2018 13:40:41 -0800
A vlan device with vid 0 is allow to creat by not able to be fully
cleaned up by unregister_vlan_dev() which checks for vlan_id!=0.

Also, VLAN 0 is probably not a valid number and it is kinda
"reserved" for HW accelerating devices, but it is probably too
late to reject it from creation even if makes sense. Instead,
just remove the check in unregister_vlan_dev().

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Fixes: ad1afb003939 ("vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)")
Cc: Vlad Yasevich <redacted>
Cc: Ben Hutchings <redacted>
Signed-off-by: Cong Wang <redacted>
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help