Thread (6 messages) flat view 6 messages, 3 authors, 2018-01-10

Re: [PATCH bpf-next 2/2] net: free RX queue structures

From: Jesper Dangaard Brouer <hidden>
Date: 2018-01-10 10:59:17

On Wed, 10 Jan 2018 01:20:02 -0800
Jakub Kicinski [off-list ref] wrote:
Looks like commit e817f85652c1 ("xdp: generic XDP handling of
xdp_rxq_info") replaced kvfree(dev->_rx) in free_netdev() with
a call to netif_free_rx_queues() which doesn't actually free
the rings?

While at it remove the unnecessary temporary variable.

Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
Signed-off-by: Jakub Kicinski <redacted>
Reviewed-by: Simon Horman <redacted>
Acked-by: Jesper Dangaard Brouer <redacted>

Thanks for fixing this!

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help