Thread (3 messages) flat view 3 messages, 3 authors, 2018-01-10

Re: [PATCH] doc: clarification about setting SO_ZEROCOPY

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2018-01-09 13:06:02

On Tue, Jan 9, 2018 at 3:52 AM, Kornilios Kourtis [off-list ref] wrote:
Signed-off-by: Kornilios Kourtis <redacted>
Acked-by: Willem de Bruijn <willemb@google.com>

Thanks, Kornilios.
quoted hunk ↗ jump to hunk
---
 Documentation/networking/msg_zerocopy.rst | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/Documentation/networking/msg_zerocopy.rst b/Documentation/networking/msg_zerocopy.rst
index 77f6d7e..c3380f4 100644
--- a/Documentation/networking/msg_zerocopy.rst
+++ b/Documentation/networking/msg_zerocopy.rst
@@ -72,6 +72,10 @@ this flag, a process must first signal intent by setting a socket option:
        if (setsockopt(fd, SOL_SOCKET, SO_ZEROCOPY, &one, sizeof(one)))
                error(1, errno, "setsockopt zerocopy");

+Setting the socket option only works when the socket is in its initial
+(TCP_CLOSED) state.  Trying to set the option for a socket returned by accept(),
+for example, will lead to an EBUSY error. In this case, the option should be set
+to the listening socket and it will be inherited by the accepted sockets.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help