Re: [PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Andy-Gospodarek/net-create-dynamic-software-irq-moderation-library/20180109-182838
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:15: sparse: no member 'rx_am_enabled' in struct mlx5e_params

quoted

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: call with no type!
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: call with no type!
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: unknown expression (14 0)

   drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: unknown expression (30 46)

quoted

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: unknown expression (14 0)
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:15: sparse: generating address of non-lvalue (8)

   drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_build_rep_params':
   drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:10: error: 'struct mlx5e_params' has no member named 'rx_am_enabled'; did you mean
    params->rx_am_enabled = MLX5_CAP_GEN(mdev, cq_moderation);
    ^~~~~~~~~~~~~
    rx_dim_enabled

vim +887 drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

cb67b832 Hadar Hen Zion 2016-07-01  875  
6a9764ef Saeed Mahameed 2016-12-21  876  static void mlx5e_build_rep_params(struct mlx5_core_dev *mdev,
6a9764ef Saeed Mahameed 2016-12-21  877  				   struct mlx5e_params *params)
cb67b832 Hadar Hen Zion 2016-07-01  878  {
cb67b832 Hadar Hen Zion 2016-07-01  879  	u8 cq_period_mode = MLX5_CAP_GEN(mdev, cq_period_start_from_cqe) ?
cb67b832 Hadar Hen Zion 2016-07-01  880  					 MLX5_CQ_PERIOD_MODE_START_FROM_CQE :
cb67b832 Hadar Hen Zion 2016-07-01  881  					 MLX5_CQ_PERIOD_MODE_START_FROM_EQE;
cb67b832 Hadar Hen Zion 2016-07-01  882  
6a9764ef Saeed Mahameed 2016-12-21  883  	params->log_sq_size = MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE;
6a9764ef Saeed Mahameed 2016-12-21  884  	params->rq_wq_type  = MLX5_WQ_TYPE_LINKED_LIST;
6a9764ef Saeed Mahameed 2016-12-21  885  	params->log_rq_size = MLX5E_PARAMS_MINIMUM_LOG_RQ_SIZE;
cb67b832 Hadar Hen Zion 2016-07-01  886  
6a9764ef Saeed Mahameed 2016-12-21 @887  	params->rx_am_enabled = MLX5_CAP_GEN(mdev, cq_moderation);
6a9764ef Saeed Mahameed 2016-12-21  888  	mlx5e_set_rx_cq_mode_params(params, cq_period_mode);
cb67b832 Hadar Hen Zion 2016-07-01  889  
6a9764ef Saeed Mahameed 2016-12-21  890  	params->tx_max_inline         = mlx5e_get_max_inline_cap(mdev);
6a9764ef Saeed Mahameed 2016-12-21  891  	params->num_tc                = 1;
6a9764ef Saeed Mahameed 2016-12-21  892  	params->lro_wqe_sz            = MLX5E_PARAMS_DEFAULT_LRO_WQE_SZ;
5f195c2c Chris Mi       2017-05-16  893  
5f195c2c Chris Mi       2017-05-16  894  	mlx5_query_min_inline(mdev, &params->tx_min_inline_mode);
cb67b832 Hadar Hen Zion 2016-07-01  895  }
cb67b832 Hadar Hen Zion 2016-07-01  896  

:::::: The code at line 887 was first introduced by commit
:::::: 6a9764efb255f49a91e229799c38d5c1c9361987 net/mlx5e: Isolate open_channels from priv->params

:::::: TO: Saeed Mahameed [off-list ref]
:::::: CC: Saeed Mahameed [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation