Thread (3 messages) 3 messages, 3 authors, 2018-01-25

Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup()

From: David Miller <davem@davemloft.net>
Date: 2018-01-09 02:02:37

From: Al Viro <redacted>
Date: Fri, 05 Jan 2018 19:31:58 +0000
Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane()
had been taking iomem address to access as the first argument; its
predecessor (->ctrl_ane()) used to take struct mac_device_info instead.

One of the callers had not been converted; as the result, instead of
reading and modifying a word in card iomem we read and modify a word
in (or near) the in-core strucct mac_device_info.

Fixes: 70523e639bf8 (drivers: net: stmmac: reworking the PCS code)
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Yikes...

Al, can you split the bug fixes like this one into a separate series
for me to pull into my net GIT tree?

Don't include the pure annotation or partial endianness conversion
ones, those should go to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help