Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

On 1/7/18 7:03 PM, Chris Mi wrote:

quoted

Did you measure the effect of increasing batch sizes?

Yes. Even if we enlarge the batch size bigger than 10, there is no big improvement.

That will change over time so the tc command should allow auto-batching
to work up to the message size limit.

I think that's because current kernel doesn't process the requests in parallel.
If kernel processes the requests in parallel, I believe specifying a bigger batch size
will get a better result.

quoted

I wonder whether specifying the batch size is necessary at all. Couldn't batch
mode just collect messages until either EOF or an incompatible command is
encountered which then triggers a commit to kernel? This might simplify
code quite a bit.

That's a good suggestion.

Thanks for your time on this, Chris.