Thread (4 messages) flat view 4 messages, 2 authors, 2018-01-05

Re: [PATCH net-next 0/2] rds: use RCU between work-enqueue and connection teardown

From: David Miller <davem@davemloft.net>
Date: 2018-01-05 18:39:36

From: Sowmini Varadhan <redacted>
Date: Thu,  4 Jan 2018 06:52:58 -0800
This patchset follows up on the root-cause mentioned in
https://www.spinics.net/lists/netdev/msg472849.html

Patch1 implements some code refactoring that was suggeseted
as an enhancement in http://patchwork.ozlabs.org/patch/843157/
It replaces the c_destroy_in_prog bit in rds_connection with 
an atomically managed flag in rds_conn_path.

Patch2 builds on Patch1 and uses RCU to make sure that 
work is only enqueued if the connection destroy is not already
in progress: the test-flag-and-enqueue is done under rcu_read_lock,
while destroy first sets the flag, uses synchronize_rcu to 
wait for existing reader threads to complete, and then starts
all the work-cancellation.

Since I have not been able to reproduce the original stack traces
reported by syszbot, and these are fixes for a race condition that
are based on code-inspection I am not marking these as reported-by 
at this time.
Series applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help