Thread (4 messages) flat view 4 messages, 2 authors, 2018-01-04

"lockless" qdisc breaks tx_queue_len change too?

From: Cong Wang <hidden>
Date: 2018-01-03 04:41:41

Hi, John

While reviewing your ptr_ring fix again today, it looks like your
"lockless" qdisc patchset breaks dev->tx_queue_len behavior.

Before your patchset, dev->tx_queue_len is merely an integer to read,
after your patchset, the skb array has to be resized when
dev->tx_queue_len changes, but I don't see any qdisc code handles
this...

Also, because of that, I doubt __skb_array_empty() in
pfifo_fast_dequeue() can be safe any more even with your ptr_ring fix.

What am I missing?

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help