Re: [PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

From: Linus Walleij <redacted>
Date: Wed, 6 Dec 2017 14:02:49 +0100

On Mon, Dec 4, 2017 at 12:21 AM, David Miller [off-list ref] wrote:

quoted

quoted

+static irqreturn_t gemini_port_irq_thread(int irq, void *data)
+{
+     struct gemini_ethernet_port *port = data;
+     struct gemini_ethernet *geth = port->geth;
+     unsigned long irqmask = SWFQ_EMPTY_INT_BIT;
+     unsigned long flags;

Always order local variables in reverse-christmas-tree format,
which is longest to shortest line.

It's hard to do in cases like this where I use the variable
when defining another variable:

struct gemini_ethernet_port *port = netdev_priv(netdev);
void __iomem *status_reg = port->gmac_base + GMAC_STATUS;

But I understand the aesthetic, so I fix it as well as I can.

If you want me to even rewrite the above using more lines of code
to keep the aestetic (moving assignment out of the variable
definitions), tell me and I can fix that too, whatever you like.

Yes, that is the way generally we recommend doing this.  Move
the troublesome assignment down into the actual function body.