Re: [PATCH v5 3/6] perf: implement pmu perf_kprobe
- From
- Peter Zijlstra <peterz@infradead.org>
- Date
- 2017-12-20 10:03:18
- Also in
- lkml
- Reply to
- Song Liu, 2017-12-06
On Wed, Dec 06, 2017 at 02:45:15PM -0800, Song Liu wrote:
quoted hunk ↗ jump to hunk
@@ -8537,7 +8620,7 @@ static int perf_event_set_filter(struct perf_event *event, void __user *arg) char *filter_str; int ret = -EINVAL; - if ((event->attr.type != PERF_TYPE_TRACEPOINT || + if ((!perf_event_is_tracing(event) || !IS_ENABLED(CONFIG_EVENT_TRACING)) && !has_addr_filter(event)) return -EINVAL;
You actually missed an instance later in this same function... fixing
that.