[PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

Subsystems: atheros ath generic utilities, qualcomm wcn36xx wireless driver, the rest

STALE3216d

4 messages, 3 authors, 2017-12-29 · open the first message on its own page

[PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

From: Colin King <hidden>
Date: 2017-12-19 17:04:16 

From: Colin Ian King <redacted>

msg_body.min_ch_time is being assigned twice; remove the redundant
first assignment.

Detected by CoverityScan, CID#1463042 ("Unused Value")

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 2914618a0335..bab2eca5fcac 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -625,7 +625,6 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif,
 	INIT_HAL_MSG(msg_body, WCN36XX_HAL_START_SCAN_OFFLOAD_REQ);
 
 	msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE;
-	msg_body.min_ch_time = 30;
 	msg_body.min_ch_time = 100;
 	msg_body.scan_hidden = 1;
 	memcpy(msg_body.mac, vif->addr, ETH_ALEN);
-- 
2.14.1

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

From: Bjorn Andersson <hidden>
Date: 2017-12-26 20:13:17 

On Tue 19 Dec 09:04 PST 2017, Colin King wrote:

From: Colin Ian King <redacted>

msg_body.min_ch_time is being assigned twice; remove the redundant
first assignment.

Detected by CoverityScan, CID#1463042 ("Unused Value")
Happy to see Coverity working for us :)


This should have had a:

Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support")
quoted hunk
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 2914618a0335..bab2eca5fcac 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -625,7 +625,6 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif,
 	INIT_HAL_MSG(msg_body, WCN36XX_HAL_START_SCAN_OFFLOAD_REQ);
 
 	msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE;
-	msg_body.min_ch_time = 30;
 	msg_body.min_ch_time = 100;
But I strongly suspect the second line is supposed to be max_ch_time.

@Loic, do you agree?

Regards,
Bjorn

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

From: Loic Poulain <hidden>
Date: 2017-12-29 07:45:05 

Hi Colin, Bjorn,

On 26 December 2017 at 21:13, Bjorn Andersson
[off-list ref] wrote:
On Tue 19 Dec 09:04 PST 2017, Colin King wrote:
quoted
From: Colin Ian King <redacted>

msg_body.min_ch_time is being assigned twice; remove the redundant
first assignment.

Detected by CoverityScan, CID#1463042 ("Unused Value")
Happy to see Coverity working for us :)


This should have had a:

Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support")
quoted
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 2914618a0335..bab2eca5fcac 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -625,7 +625,6 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif,
      INIT_HAL_MSG(msg_body, WCN36XX_HAL_START_SCAN_OFFLOAD_REQ);

      msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE;
-     msg_body.min_ch_time = 30;
      msg_body.min_ch_time = 100;
But I strongly suspect the second line is supposed to be max_ch_time.

@Loic, do you agree?
You're absolutely right.
Colin could you please update your patch accordingly?

Regards,
Loic

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

From: Colin Ian King <hidden>
Date: 2017-12-29 10:52:46 

On 29/12/17 07:44, Loic Poulain wrote:
Hi Colin, Bjorn,

On 26 December 2017 at 21:13, Bjorn Andersson
[off-list ref] wrote:
quoted
On Tue 19 Dec 09:04 PST 2017, Colin King wrote:
quoted
From: Colin Ian King <redacted>

msg_body.min_ch_time is being assigned twice; remove the redundant
first assignment.

Detected by CoverityScan, CID#1463042 ("Unused Value")
Happy to see Coverity working for us :)


This should have had a:

Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support")
quoted
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 2914618a0335..bab2eca5fcac 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -625,7 +625,6 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif,
      INIT_HAL_MSG(msg_body, WCN36XX_HAL_START_SCAN_OFFLOAD_REQ);

      msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE;
-     msg_body.min_ch_time = 30;
      msg_body.min_ch_time = 100;
But I strongly suspect the second line is supposed to be max_ch_time.

@Loic, do you agree?
You're absolutely right.
Colin could you please update your patch accordingly?
Resent as "wcn36xx: fix incorrect assignment to msg_body.min_ch_time"

Regards,
Loic
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help