Thread (3 messages) 3 messages, 3 authors, 2017-12-18

Re: [PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static

flat view

From: Florian Westphal <fw@strlen.de>
Date: 2017-12-11 09:19:51
Also in: kernel-janitors, lkml, netfilter-devel

Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

The structure nf_conntrack_l4proto_gre4  is local to the source and does
not need to be in global scope, so make it static.
This bug was added in
commit b9679a9fd3a7d36ea3deb2864a00cc413c5aae28
netfilter: conntrack: l4 protocol trackers can be const
-struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = {
+static struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = {
This should be 'static const'.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help