Thread (2 messages) 2 messages, 2 authors, 2017-12-07

Re: [PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-12-07 18:52:10
Also in: linux-arm-kernel, linux-rockchip, lkml

From: Branislav Radocaj <redacted>
Date: Thu,  7 Dec 2017 00:07:38 +0100
If clk_set_rate() fails, we should disable clk before return.
Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Branislav Radocaj <redacted>
Ok, but this probe routine is very inconsistent in how it handles
clock rate setting failures now.

Above your changes, if the RGMII clk can't have it's rate set, we
just continue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help