Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends
flat view
From: Michael Chan <michael.chan@broadcom.com>
Date: 2017-12-06 19:27:36
Also in:
lkml
On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer [off-list ref] wrote:
quoted hunk ↗ jump to hunk
bnxt driver spams logfiles with [ 541.003065] bnxt_en 0000:5d:00.1 eth5: Link speed -1 no longer supported if a direct attached cable (DAC) is plugged into the bnxt card and is unplugged on the other side. This patch removes the code printing this message, since it doesn't provide any useful information. Signed-off-by: Thomas Bogendoerfer <redacted> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 --------- 1 file changed, 9 deletions(-)diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 8c1dd60eab6f..8a2319ed79dc 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c@@ -1701,18 +1701,9 @@ static int bnxt_async_event_process(struct bnxt *bp, /* TODO CHIMP_FW: Define event id's for link change, error etc */ switch (event_id) { case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE: { - u32 data1 = le32_to_cpu(cmpl->event_data1); - struct bnxt_link_info *link_info = &bp->link_info; - if (BNXT_VF(bp)) goto async_event_process_exit; - if (data1 & 0x20000) { - u16 fw_speed = link_info->force_link_speed; - u32 speed = bnxt_fw_to_ethtool_speed(fw_speed); - netdev_warn(bp->dev, "Link speed %d no longer supported\n", - speed); - }
This is supposed to provide useful information to the user under some conditions. In your particular situation, it is not useful since the speed is -1. Let me try to modify this code a bit to reduce the spam. I will post a revised patch in the next 2 hours. Thanks.
set_bit(BNXT_LINK_SPEED_CHNG_SP_EVENT, &bp->sp_event);
/* fall thru */
}
--
2.12.3