Re: [PATCH ipsec] xfrm: fix rcu usage in xfrm_get_type_offload
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2017-12-31 16:09:15
On Sun, Dec 31, 2017 at 04:18:56PM +0100, Sabrina Dubroca wrote:
request_module can sleep, thus we cannot hold rcu_read_lock() while
calling it. The function also jumps back and takes rcu_read_lock()
again (in xfrm_state_get_afinfo()), resulting in an imbalance.
This codepath is triggered whenever a new offloaded state is created.
Fixes: ffdb5211da1c ("xfrm: Auto-load xfrm offload modules")
Reported-by: syzbot+ca425f44816d749e8eb49755567a75ee48cf4a30@syzkaller.appspotmail.com
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>Patch applied, thanks a lot for the fix Sabrina!