Thread (22 messages) 22 messages, 5 authors, 2017-12-27

Re: [bpf-next V2 PATCH 01/14] xdp: base API for new XDP rx-queue info concept

From: Jakub Kicinski <hidden>
Date: 2017-12-23 00:14:47

On Fri, 22 Dec 2017 18:11:39 +0100, Jesper Dangaard Brouer wrote:
+struct xdp_rxq_info {
+	struct net_device *dev;
+	u32 queue_index;
+	u32 reg_state;
+} ____cacheline_aligned; /* perf critical, avoid false-sharing */
I'm assuming this is cacheline_aligned, because of some stuff you will
add here in the future for the completion path?  (The comment could
mention that this data is read-mostly.)  Drivers are likely to already
have a read-mostly (or unused-mostly) section of the rx ring structure.
Would it be possible to define this in a way that would allow people
who carefully lay out their data path structures to save cache space?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help