Re: [PATCH v3 next-queue 05/10] ixgbe: add ipsec offload add and remove SA

On Wed, Dec 20, 2017 at 05:39:13PM -0800, Shannon Nelson wrote:

On 12/20/2017 5:17 PM, Marcelo Ricardo Leitner wrote:

quoted

Hi,

On Tue, Dec 19, 2017 at 03:59:57PM -0800, Shannon Nelson wrote:

quoted

+}
+
+static const struct xfrmdev_ops ixgbe_xfrmdev_ops = {
+	.xdo_dev_state_add = ixgbe_ipsec_add_sa,
+	.xdo_dev_state_delete = ixgbe_ipsec_del_sa,
+};
+

This struct is only declared if XFRM_OFFLOAD is selected. What is
selecting it for ixgbe driver?
mlx5 driver has an extra option for ipsec offload and it then does
'depends on XFRM_OFFLOAD'

   Marcelo

I didn't bother putting a 'depends' item in the ixgbe's Kconfig entry, and I
didn't create an extra CONFIG variable to enable ixgbe's support of the
offload.  If CONFIG_XFRM_OFFLOAD is set, then ixgbe will support it.

You handled it via Makefile, okay. Missed it on patch 2, my bad.

Anyhow, we probably could use some standard here across the vendors
here.  With this patchset, we have 2 drivers supporting it, and 2
different ways to configure it.

  Marcelo