Re: [for-next 01/11] net/mlx5: E-Switch, Refactor vport representors initialization
flat view
From: David Miller <hidden>
Date: 2017-12-20 17:57:34
Also in:
linux-rdma
From: Saeed Mahameed <saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Date: Tue, 19 Dec 2017 12:33:30 -0800
quoted hunk
+int esw_offloads_init_reps(struct mlx5_eswitch *esw) +{ + struct mlx5_core_dev *dev = esw->dev; + struct mlx5_esw_offload *offloads; + struct mlx5_eswitch_rep *rep; + int total_vfs = MLX5_TOTAL_VPORTS(dev); + u8 hw_id[ETH_ALEN]; + int vport;
Reverse christmas-tree please.
quoted hunk
+ esw->offloads.vport_reps = + kcalloc(total_vfs, sizeof(struct mlx5_eswitch_rep), + GFP_KERNEL);
That looks really unpleasant: x = kcalloc(y, z, GFP_KERNEL); would look so much nicer. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html