[PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device
flat view
STALE3218d
From: Serhey Popovych <hidden>
Date: 2017-12-20 07:38:06
Subsystem:
the rest · Maintainer:
Linus Torvalds
It is already given for original device we configure this
peer for.
Results from following command before/after change applied
are shown below:
$ ip link add dev veth1a type veth peer name veth1b \
type veth peer name veth1c
Before:
-------
<no output, no netdevs created>
After:
------
Error: argument "type" is wrong: not supported for peer
Signed-off-by: Serhey Popovych <redacted>
---
ip/iplink_vxcan.c | 3 +++
ip/link_veth.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/ip/iplink_vxcan.c b/ip/iplink_vxcan.c
index c13224c..13f2577 100644
--- a/ip/iplink_vxcan.c
+++ b/ip/iplink_vxcan.c@@ -65,6 +65,9 @@ static int vxcan_parse_opt(struct link_util *lu, int argc, char **argv, if (err < 0) return err; + if (type) + invarg("not supported for peer", "type"); + if (name) { addattr_l(hdr, 1024, IFLA_IFNAME, name, strlen(name) + 1);
diff --git a/ip/link_veth.c b/ip/link_veth.c
index fcfd1ef..cc43198 100644
--- a/ip/link_veth.c
+++ b/ip/link_veth.c@@ -63,6 +63,9 @@ static int veth_parse_opt(struct link_util *lu, int argc, char **argv, if (err < 0) return err; + if (type) + invarg("not supported for peer", "type"); + if (name) { addattr_l(hdr, 1024, IFLA_IFNAME, name, strlen(name) + 1);
--
1.7.10.4