RE: [PATCH v3 net-next 1/6] tcp: Add clean acked data hook

TLS records should be attached to skbs ?

It seems more reasonable to free TLS when skb are freed, and not in
general tcp_ack() path.

We've considered it, but then we would have to touch all the places the TCP stack splits or merges SKBs. Seems more intrusive.

quoted

quoted

2) Since you do not pass any state here, this looks very suspicious to
me.

The state we need is the acknowledged sequence and it located in the

socket.

quoted

quoted

So it looks like TCP stack is bleeding all over the places ?

So in the future, a change in TCP stack will have to make sure we do
not break net/tls/... compilation.

Not pretty.

I guess we could pass the ack sequence number in that callback.
Would that address the issue?