Re: [PATCH v2 iproute2 net-next] erspan: add erspan version II support

On Fri, Dec 15, 2017 at 3:58 PM, Roman Mashak [off-list ref] wrote:

William Tu [off-list ref] writes:

quoted

The patch adds support for configuring the erspan v2, for both
ipv4 and ipv6 erspan implementation.  Three additional fields
are added: 'erspan_ver' for distinguishing v1 or v2, 'erspan_dir'
for specifying direction of the mirrored traffic, and 'erspan_hwid'
for users to set ERSPAN engine ID within a system.

As for manpage, the ERSPAN descriptions used to be under GRE, IPIP,
SIT Type paragraph.  Since IP6GRE/IP6GRETAP also supports ERSPAN,
the patch removes the old one, creates a separate ERSPAN paragrah,
and adds an example.

Signed-off-by: William Tu <redacted>
---
change in v2:
  - clean up and update manpage.
---
 include/uapi/linux/if_ether.h  |  1 +
 include/uapi/linux/if_tunnel.h |  3 ++
 ip/link_gre.c                  | 59 ++++++++++++++++++++++++--
 ip/link_gre6.c                 | 61 +++++++++++++++++++++++++--
 man/man8/ip-link.8.in          | 94 ++++++++++++++++++++++++++++++++++++------
 5 files changed, 199 insertions(+), 19 deletions(-)

diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h
index 2eb529a90250..5fd5c12ef8e9 100644
--- a/include/uapi/linux/if_ether.h
+++ b/include/uapi/linux/if_ether.h

@@ -47,6 +47,7 @@
 #define ETH_P_PUP    0x0200          /* Xerox PUP packet             */
 #define ETH_P_PUPAT  0x0201          /* Xerox PUP Addr Trans packet  */
 #define ETH_P_TSN    0x22F0          /* TSN (IEEE 1722) packet       */
+#define ETH_P_ERsPAN2        0x22EB          /* ERSPAN version 2 (type III)  */

             ^ Is it intention to have a lower case 's' in macro name or typo?

[...]

Sorry, that's my mistake. Let me fix it and resubmit. Thank you.

William