Re: [PATCH net-next 1/3] tcp: do not overshoot window_clamp in tcp_rcv_space_adjust()

From
Neal Cardwell <ncardwell@google.com>
Date
2017-12-11 17:47:33
Reply to
Eric Dumazet, 2017-12-11
On Sun, Dec 10, 2017 at 8:55 PM, Eric Dumazet [off-list ref] wrote:
While rcvbuf is properly clamped by tcp_rmem[2], rcvwin
is left to a potentially too big value.

It has no serious effect, since :
1) tcp_grow_window() has very strict checks.
2) window_clamp can be mangled by user space to any value anyway.

tcp_init_buffer_space() and companions use tcp_full_space(),
we use tcp_win_from_space() to avoid reloading sk->sk_rcvbuf

Signed-off-by: Eric Dumazet <redacted>
Acked-by: Soheil Hassas Yeganeh <redacted>
Acked-by: Wei Wang <redacted>
---
Acked-by: Neal Cardwell <ncardwell@google.com>

Thanks, Eric!

neal
Thread (8 messages) 8 messages, 3 authors, last reply 2017-12-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help