Thread (6 messages) 6 messages, 2 authors, 2017-12-07

RE: [PATCH net-next] netdevsim: check return value of debugfs_create_dir

flat view

From: Prashant Bhole <hidden>
Date: 2017-12-07 04:12:02

From: Jakub Kicinski [mailto:jakub.kicinski@netronome.com]

On Thu,  7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote:
quoted
- Handled debugfs_create_dir failure in nsim_init()
- Fixed return value of nsim_module_init() when debugfs_create_dir
fails

Signed-off-by: Prashant Bhole <redacted>
Why?  Failing to expose the state via DebugFS is not fatal to the driver.
Ok, my intention was to handle the return code properly, which is not needed
as per your comment.
Shall I remove the existing handling in nsim_module_init() in separate
patch?  Because it will prevent netdevsim from loading when debugfs is
disabled.

Thanks,
Prashant
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help