Re: [PATCH v2 iproute2 net-next] gre6: add collect metadata support
flat view
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-12-06 01:07:39
On Tue, 5 Dec 2017 15:10:37 -0800 William Tu [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index a6a10e577b1f..eb04f887c940 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip-link.8.in@@ -755,6 +755,8 @@ the following additional arguments are supported: .BI "dscp inherit" ] [ .BI dev " PHYS_DEV " +] [ +.RB external ] .in +8@@ -833,6 +835,10 @@ or .IR 00 ".." ff when tunneling non-IP packets. The default value is 00. +.sp +.RB external +- make this tunnel externally controlled (or not, which is the default). + .in -8
I don't have any direct involvement in offload, so would like some feedback from others that are. Not a big fan of opaque "metadata" what exactly does it mean? Also "external" is already used to mean something else on other parts of the link command. Also the option, and the value in JSON should be the same. Please reconsider the naming and resubmit The wording in the man page here could be better